Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Index.__new__ with Interval/Period data and object dtype #30635

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

jbrockmendel
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

xref #17246, #21311

After this we now use the same pattern when calling DatetimeIndex, TimedeltaIndex, PeriodIndex, and IntervalIndex, so we can make a helper function and de-duplicate this code.

The cases of categorical or range data with object-dtype are not yet handled.

@jreback jreback added Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses labels Jan 3, 2020
@jreback jreback added this to the 1.0 milestone Jan 3, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 09e4b78 into pandas-dev:master Jan 3, 2020
@jbrockmendel jbrockmendel deleted the ref-idx-constructor-3 branch January 3, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants