-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Regression testing for fixed issues #30554
TST: Regression testing for fixed issues #30554
Conversation
pandas/tests/indexes/test_numeric.py
Outdated
def test_get_indexer_nan(self): | ||
# GH 7820 | ||
result = Index([1, 2, np.nan]).get_indexer([np.nan]) | ||
expected = np.array([2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected = np.array([2]) | |
expected = np.array([2], dtype=np.intp) |
buf = io.StringIO() | ||
s.to_csv(buf) | ||
result = buf.getvalue() | ||
expected = ",0\n0,0 days 00:00:00.000000001\n1,0 days 00:00:00.000000001\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected = ",0\n0,0 days 00:00:00.000000001\n1,0 days 00:00:00.000000001\n" | |
expected_rows = [ | |
",0", | |
"0,0 days 00:00:00.000000001", | |
"1,0 days 00:00:00.000000001", | |
] | |
expected = tm.convert_rows_list_to_csv_str(expected_rows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. merge on green.
Fixed one of the 32-bit failures. We may have a remaining one that I don't immediately see a fix for.
|
at least one of the failures looks like a np.intp thing |
Strange, on the 32-bit linux build we have
Does that make sense? Still not sure about the to_csv one. We might want to drop that test / issue from the list and merge the rest. |
@TomAugspurger the original 2 Windows failures are fixed with the suggestions above (tested locally) |
Sorry, I missed that! Will push that up. |
Thanks! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff