TST: add test for df comparing strings to numbers raises ValueError #29535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 11, 2019
pandas/tests/frame/test_operators.py
Outdated
| {x: {"x": "foo", "y": "bar", "z": "baz"} for x in ["a", "b", "c"]} | ||
| ) | ||
| with pytest.raises(TypeError): | ||
| df > 0 |
There was a problem hiding this comment.
Can you pytest.mark.parameterize over all the operators? I think we have a fixture.
There was a problem hiding this comment.
Thanks, @mroeschke - now using parameterize to go over ["lt", "le", "gt", "ge", "eq", "ne"].
mroeschke
added
Numeric Operations
mroeschke
reviewed
Nov 11, 2019
pandas/tests/frame/test_operators.py
Outdated
| @@ -530,6 +530,34 @@ def test_comp(func): | |||
| test_comp(operator.ge) | |||
| test_comp(operator.le) | |||
|
|
|||
| @pytest.mark.parametrize("op", ["lt", "le", "gt", "ge", "eq", "ne"]) | |||
There was a problem hiding this comment.
Can you use the compare_operators_no_eq_ne pytest fixture instead?
There was a problem hiding this comment.
Thanks, @mroeschke - that was neat! Now using compare_operators_no_eq_ne.
mroeschke
approved these changes
Nov 12, 2019
|
thanks @ganevgv |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff