Fix mypy error messages in pandas/test/tseries/offsets/test_offsets.py #29340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Typing
|
lgtm @simonjayhawkins |
38 tasks
simonjayhawkins
changed the title
simonjayhawkins
approved these changes
Nov 2, 2019
WillAyd
requested changes
Nov 2, 2019
| @@ -90,6 +90,7 @@ def test_to_M8(): | |||
| ##### | |||
| # DateOffset Tests | |||
| ##### | |||
| _ApplyCases = List[Tuple[int, Dict[datetime, datetime]]] | |||
There was a problem hiding this comment.
Suggested change
| _ApplyCases = List[Tuple[int, Dict[datetime, datetime]]] | |
| _ApplyCases = List[Tuple[BaseOffset, Dict[datetime, datetime]]] |
Kind of tricky but I don't think int is in play at all here but these are rather all BaseOffset subclasses.
This only "works" because there is no stub for pandas.tseries.offsets and all of the instances here resolve to Any. Assumedly if we stubbed that module it would cause failures if this stays as int
There was a problem hiding this comment.
good point. Have just pushed this change.
WillAyd
approved these changes
Nov 7, 2019
|
Great thanks @samuelsinayoko |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate and fix mypy for test offsets
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff