fixed issue of mypy for test_ujson #29022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @iamrajhans! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-18 06:38:56 UTC |
38 tasks
simonjayhawkins
requested changes
Oct 16, 2019
simonjayhawkins
approved these changes
Oct 16, 2019
WillAyd
requested changes
Oct 16, 2019
pandas/tests/io/json/test_ujson.py
Outdated
| @@ -1,7 +1,10 @@ | |||
| try: | |||
There was a problem hiding this comment.
Can you get rid of the try...except altogether? This looks like legacy code - import json should work dating back to at least Python 2.6
There was a problem hiding this comment.
sure, will do it
There was a problem hiding this comment.
@WillAyd I have done the changes, please review
WillAyd
approved these changes
Oct 18, 2019
|
Thanks @iamrajhans |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff