Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy error in pandas\tests\indexes\interval\test_interval_tree.py #29021

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Fix mypy error in pandas\tests\indexes\interval\test_interval_tree.py #29021

merged 7 commits into from
Nov 7, 2019

Conversation

pqzx
Copy link
Contributor

@pqzx pqzx commented Oct 16, 2019

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Oct 16, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pqzx Thanks for the PR.

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Oct 16, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 16, 2019

Hello @pqzx! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-06 23:07:39 UTC

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd
Copy link
Member

WillAyd commented Oct 16, 2019

Hmm just out of curiosity does this work if you did (list(x) for x in permutations(range(3))). Assuming equivalent I think would be easier to track than the type ignore

@pqzx
Copy link
Contributor Author

pqzx commented Oct 17, 2019

Hmm just out of curiosity does this work if you did (list(x) for x in permutations(range(3))). Assuming equivalent I think would be easier to track than the type ignore

Yes, this works. Updated to use this instead.

@simonjayhawkins
Copy link
Member

@pqzx can you fix lint error and merge master

@pqzx
Copy link
Contributor Author

pqzx commented Oct 22, 2019

@simonjayhawkins sorry for the noob question, what's the lint error in this case? Is it the line length?

@WillAyd
Copy link
Member

WillAyd commented Oct 23, 2019

Looks like the checks are fine. I think if you merge master and try again should work (have had intermittent failures recently)

@simonjayhawkins
Copy link
Member

@WillAyd OK to merge?

@WillAyd WillAyd merged commit 235d120 into pandas-dev:master Nov 7, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 7, 2019

Thanks @pqzx !

@pqzx pqzx deleted the fix-mypy-test-interval-tree branch November 8, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants