fix #28926 mypy error in pandas\tests\arrays\test_array.py #28970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm @simonjayhawkins |
|
Was (accidentally) also looking into this fix. However, I believe this is also the fix for:
pandas\tests\arrays\test_period.py:245: error: Argument "freq" to "period_array" has incompatible type "str"; expected "Optional[Tick]"
pandas\tests\test_base.py:1312: error: Argument "freq" to "period_array" has incompatible type "str"; expected "Optional[Tick]"
pandas\tests\test_base.py:1354: error: Argument "freq" to "period_array" has incompatible type "str"; expected "Optional[Tick]"This implies the entries for both of these files should also be removed from setup.cfg |
38 tasks
simonjayhawkins
requested changes
Oct 15, 2019
There was a problem hiding this comment.
@yogendrasoni lgtm. can you also remove the sections in setup.cfg for pandas\tests\arrays\test_period.py and pandas\tests\test_base.py see #28970 (comment)
…py and pandas\tests\test_base.py
There was a problem hiding this comment.
@yogendrasoni Thanks for making those changes. ci failures are unrelated. see #29008
simonjayhawkins
requested changes
Oct 16, 2019
|
@yogendrasoni in merging master the section in setup.cfg for pandas\tests\arrays\test_period.py was reinstated. can you remove. |
simonjayhawkins
approved these changes
Oct 21, 2019
|
Thanks @yogendrasoni |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Oct 23, 2019
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff