Eliminated _WriterBase class, removed unused fixtures from methods in pandas/io/excel/test_writers.py

[dayoreke]

• xref Add more pytest idiom to io.excel testing #26784
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[WillAyd]

Thanks for taking a look - this one might be tricky. Do you see a good way to keep all of the fixtures together? The downside to this approach is its not very clear the order in which the fixtures and parameters are getting injected

[pep8speaks]

Hello @dayoreke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-13 21:31:37 UTC

[simonjayhawkins]

see #28753 (comment)

[simonjayhawkins]

Thanks for taking a look - this one might be tricky.

this addresses Eliminate _WriterBase class and engine and ext injected into tests #26662 (comment) from #26784

could split into two PRs if it makes it easier to review.

[WillAyd]

OK I am on board with this ex @simonjayhawkins outstanding comments

[simonjayhawkins]

test_basics_with_nan failing.

[simonjayhawkins]

@dayoreke lgtm. ping on green.

[simonjayhawkins]

Thanks @dayoreke Very nice!