TST: un-xfail incorrectly xfailed tests for maybe_promote #28564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
This was referenced Sep 22, 2019
|
@jreback gentle ping. This a blocker for a collection of PRs to fix about a third of our existing xfails. |
jreback
reviewed
Oct 1, 2019
| dtype = np.object_ | ||
|
|
||
| return dtype, fill_value | ||
|
|
||
|
|
||
| def _check_lossless_cast(value, dtype: np.dtype) -> bool: |
There was a problem hiding this comment.
this is nice, though I think we have several implementation of this (or maybe for the array form) in this file, in the future would be nice to consolidate.
There was a problem hiding this comment.
will take a look. plenty of follow-ups coming up for this. hopefully will be orthogonal and small.
|
thanks @jbrockmendel |
josibake
pushed a commit
to josibake/pandas
that referenced
this pull request
Oct 1, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sits on top of #28561.