CLN: de-kludge Block.quantile #27627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Clean
Internals
gfyoung
reviewed
Jul 28, 2019
| def quantile(self, qs, interpolation="linear", axis=0): | ||
| naive = self.values.view("M8[ns]") | ||
|
|
||
| # kludge for 2D block with 1D values |
There was a problem hiding this comment.
"kludge" - am I to assume that you're planning on cleaning this up or splitting more cleanly in the future? One-liners like these don't seem "super-kludgy" IMO
There was a problem hiding this comment.
Yes, once we allow 2D EAs this entire method will be unnecessary.
TomAugspurger
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
LGTM. @jreback any thoughts? Otherwise I'd recommend self-merging in 24 hours @jbrockmendel.
|
@TomAugspurger i will look soonish. but I have comments on nearly all of these PRs so pls wait. |
jreback
approved these changes
Jul 31, 2019
| values = values[None, :] | ||
| else: | ||
| values = self.get_values() | ||
| values = self.get_values() |
There was a problem hiding this comment.
grr I really dis-like strongly get_values()
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from #27626 since I decided that is poorly scoped.