check early for non-scalar default_fill_value #27302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jul 9, 2019
| @@ -74,6 +75,8 @@ def __init__( | |||
| dtype=None, | |||
| copy=False, | |||
| ): | |||
| if not is_scalar(default_fill_value): | |||
There was a problem hiding this comment.
Is a dict acceptable here at all? Think we allow that for normal DataFrame fillna
There was a problem hiding this comment.
@TomAugspurger are there cases where non-scalar is accepted? I was getting errors in another branch caused by zero-dim ndarray getting through here.
There was a problem hiding this comment.
I don't believe we allow this (nor should)
Co-Authored-By: Simon Hawkins <[email protected]>
|
is there an issue for this? I guess currently this raises but its an incorrect description of the error? |
ATM this raises once it gets passed to SparseArray. The actual bug this fixes is the |
1 task
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off of an in-progress division-by-zero branch