Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test to check zero index array do not error #25856

Closed
wants to merge 1 commit into from

Conversation

illegalnumbers
Copy link
Contributor

refs GH-21946

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [na] whatsnew entry

@pep8speaks
Copy link

pep8speaks commented Mar 24, 2019

Hello @illegalnumbers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 865:80: E501 line too long (82 > 79 characters)

Comment last updated at 2019-03-24 02:57:47 UTC

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25856   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         172      172           
  Lines       52892    52892           
=======================================
  Hits        48373    48373           
  Misses       4519     4519
Flag Coverage Δ
#multiple 90.02% <ø> (ø) ⬆️
#single 41.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f9a9...4dbf456. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #25856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25856   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         172      172           
  Lines       52892    52892           
=======================================
  Hits        48373    48373           
  Misses       4519     4519
Flag Coverage Δ
#multiple 90.02% <ø> (ø) ⬆️
#single 41.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0f9a9...9c970d8. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 24, 2019

this is already fully covered by #24924

@jreback jreback closed this Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants