BUG: Display precision doesn't affect complex float numbers #25514 #25745

sakarpanta · 2019-03-16T18:10:39Z

closes Display precision doesn't affect complex float numbers #25514
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

codecov · 2019-03-16T18:47:16Z

Codecov Report

Merging #25745 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #25745      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         172      172              
  Lines       52977    52979       +2     
==========================================
+ Hits        48343    48344       +1     
- Misses       4634     4635       +1

Flag	Coverage Δ
#multiple	`89.82% <100%> (ø)`	⬆️
#single	`41.74% <50%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/frame.py	`96.79% <ø> (ø)`	⬆️
pandas/io/formats/format.py	`98% <100%> (ø)`	⬆️
pandas/util/testing.py	`88.98% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0441...0e1f3b6. Read the comment docs.

codecov · 2019-03-16T18:47:16Z

Codecov Report

Merging #25745 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #25745      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.02%     
==========================================
  Files         175      175              
  Lines       52485    52501      +16     
==========================================
+ Hits        48235    48244       +9     
- Misses       4250     4257       +7

Flag	Coverage Δ
#multiple	`90.44% <100%> (-0.01%)`	⬇️
#single	`40.73% <27.27%> (-0.16%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/frame.py	`96.79% <ø> (-0.12%)`	⬇️
pandas/io/formats/format.py	`97.91% <100%> (+0.01%)`	⬆️
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/sparse/frame.py	`95.5% <0%> (-0.2%)`	⬇️
pandas/compat/__init__.py	`77.5% <0%> (-0.15%)`	⬇️
pandas/plotting/_core.py	`83.77% <0%> (-0.09%)`	⬇️
pandas/core/computation/expr.py	`96.7% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02ec8f...3fd69e9. Read the comment docs.

pandas/core/frame.py

pandas/tests/io/formats/test_format.py

WillAyd

Can you add a whatsnew for v0.25?

simonjayhawkins · 2019-03-29T14:37:19Z

does this also change the notebook display? if so can we have a test for to_html() with notebook =True and False.

simonjayhawkins · 2019-03-29T14:41:13Z

pandas/tests/io/formats/test_format.py

@@ -1417,6 +1417,18 @@ def test_to_string_float_index(self):
                    '5.0  4')
        assert result == expected

+    def test_to_string_complex_float_formatting(self):
+        fmt.set_option('display.precision', 5)


do we need to use the context manger here?

can you use the context manager here

jreback · 2019-04-05T00:29:25Z

can you merge master and see if you can update

sakarpanta · 2019-04-05T19:20:09Z

can you merge master and see if you can update

Done.

jreback · 2019-04-07T22:01:06Z

pandas/core/frame.py

-        2      1      1.0      (1+0j)      1  True
-        3      1      1.0      (1+0j)      1  True
-        4      1      1.0      (1+0j)      1  True
+           int64  float64   complex128  object  bool


is there an extra space here?

Yes. Good catch! Thanks.

pandas/io/formats/format.py

jreback · 2019-04-07T22:03:19Z

pandas/io/formats/format.py

@@ -1094,7 +1097,10 @@ def format_values_with(float_format):
                                           for val in values.ravel()[imask]])

            if self.fixed_width:
-                return _trim_zeros(values, na_rep)
+                if is_complex:


you can do the type check right here instead of above

The problem with that is at that point the values object has been reassigned as values = np.array(values, dtype='object') and is no longer a complex type but an array with the complex numbers (or floats) as strings.

jreback · 2019-04-07T22:03:48Z

pandas/tests/io/formats/test_format.py

@@ -1417,6 +1417,18 @@ def test_to_string_float_index(self):
                    '5.0  4')
        assert result == expected

+    def test_to_string_complex_float_formatting(self):
+        fmt.set_option('display.precision', 5)


can you use the context manager here

jreback · 2019-04-07T22:04:02Z

pandas/tests/io/formats/test_format.py

+            (0.2739442392974528 + 0.23515228785438969j),
+            (0.26974928742135185 + 0.3250604054898979j)]})
+        result = df.to_string()
+        expected = ('                  x\n0  0.44678+0.07152j\n'


do these have an extra space?

No, this is how it would display normally.

jreback

minor change. ping on green.

jreback · 2019-04-12T11:50:41Z

pandas/tests/io/formats/test_format.py

@@ -1370,6 +1370,18 @@ def test_to_string_float_index(self):
                    '5.0  4')
        assert result == expected

+    def test_to_string_complex_float_formatting(self):
+        with pd.option_context('display.precision', 5):


can you add the gh issue number as a comment

jreback · 2019-04-12T17:08:36Z

thanks @sakarpanta

…v#25514 (pandas-dev#25745)

BUG: Display precision doesn't affect complex float numbers pandas-de…

0e1f3b6

…v#25514

gfyoung reviewed Mar 16, 2019

View reviewed changes

pandas/core/frame.py Show resolved Hide resolved

gfyoung reviewed Mar 16, 2019

View reviewed changes

pandas/tests/io/formats/test_format.py Show resolved Hide resolved

gfyoung added Output-Formatting __repr__ of pandas objects, to_string Numeric Operations Arithmetic, Comparison, and Logical operations labels Mar 16, 2019

WillAyd requested changes Mar 28, 2019

View reviewed changes

simonjayhawkins mentioned this pull request Mar 29, 2019

display.precision not honored for float-like values in notebook #25920

Open

simonjayhawkins reviewed Mar 29, 2019

View reviewed changes

sakarpanta added 2 commits April 2, 2019 13:57

Add whatsnew entry

34c9d0d

Fixed the zeros not being trimmed issue

6b1a365

Merge with master

d97bcd7

jreback requested changes Apr 7, 2019

View reviewed changes

sakarpanta added 3 commits April 10, 2019 21:26

Remove extra space and add context manager to test

423eea1

Merge remote-tracking branch 'upstream/master' into fix-25514

5829a77

Refactor format class list and rename _trim_zeros to _trim_zeros_float

7dc8a33

jreback requested changes Apr 12, 2019

View reviewed changes

jreback added this to the 0.25.0 milestone Apr 12, 2019

Add comment with issue pandas-dev#25514

3fd69e9

jreback approved these changes Apr 12, 2019

View reviewed changes

jreback merged commit 90a85e0 into pandas-dev:master Apr 12, 2019

yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019

BUG: Display precision doesn't affect complex float numbers pandas-de…

e70f475

…v#25514 (pandas-dev#25745)

mroeschke mentioned this pull request Jul 19, 2019

IndexError in repr of series objects containing complex numbers with negative imaginary parts #27484

Closed

simonjayhawkins mentioned this pull request Oct 2, 2020

BUG/CLN: Clean float / complex string formatting #36799

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Display precision doesn't affect complex float numbers #25514 #25745

BUG: Display precision doesn't affect complex float numbers #25514 #25745

sakarpanta commented Mar 16, 2019 •

edited

Loading

codecov bot commented Mar 16, 2019

codecov bot commented Mar 16, 2019 •

edited

Loading

WillAyd left a comment

simonjayhawkins commented Mar 29, 2019

simonjayhawkins Mar 29, 2019

jreback Mar 30, 2019

jreback Apr 7, 2019

jreback commented Apr 5, 2019

sakarpanta commented Apr 5, 2019

jreback Apr 7, 2019

sakarpanta Apr 11, 2019

jreback Apr 7, 2019

sakarpanta Apr 11, 2019 •

edited

Loading

jreback Apr 7, 2019

jreback Apr 7, 2019

sakarpanta Apr 11, 2019 •

edited

Loading

jreback left a comment

jreback Apr 12, 2019

jreback commented Apr 12, 2019

BUG: Display precision doesn't affect complex float numbers #25514 #25745

BUG: Display precision doesn't affect complex float numbers #25514 #25745

Conversation

sakarpanta commented Mar 16, 2019 • edited Loading

codecov bot commented Mar 16, 2019

Codecov Report

codecov bot commented Mar 16, 2019 • edited Loading

Codecov Report

WillAyd left a comment

Choose a reason for hiding this comment

simonjayhawkins commented Mar 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Apr 5, 2019

sakarpanta commented Apr 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sakarpanta Apr 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sakarpanta Apr 11, 2019 • edited Loading

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Apr 12, 2019

sakarpanta commented Mar 16, 2019 •

edited

Loading

codecov bot commented Mar 16, 2019 •

edited

Loading

sakarpanta Apr 11, 2019 •

edited

Loading

sakarpanta Apr 11, 2019 •

edited

Loading