Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25592 on branch 0.24.x (BUG: fix usage of na_sentinel with sort=True in factorize()) #25695

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25592: BUG: fix usage of na_sentinel with sort=True in factorize()

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Mar 12, 2019
@jorisvandenbossche jorisvandenbossche merged commit d589e58 into pandas-dev:0.24.x Mar 12, 2019
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25695 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25695      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52428    52430       +2     
==========================================
+ Hits        48441    48443       +2     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/algorithms.py 94.79% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53c9d1...5ce08c2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #25695 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25695      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52428    52430       +2     
==========================================
+ Hits        48441    48443       +2     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.83% <100%> (ø) ⬆️
#single 42.9% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/algorithms.py 94.79% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53c9d1...5ce08c2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants