Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed debugging code #25647

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Mar 11, 2019

I randomly came across this code when messing around with some Mypy configurations. It looks like this code depends on third party packages which we don't even use in the code base. They also haven't been touched in 7-8 years so I assume this is dead code.

@WillAyd WillAyd added the Clean label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25647 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25647      +/-   ##
==========================================
+ Coverage   91.26%   91.29%   +0.02%     
==========================================
  Files         173      173              
  Lines       52968    52948      -20     
==========================================
- Hits        48340    48337       -3     
+ Misses       4628     4611      -17
Flag Coverage Δ
#multiple 89.86% <ø> (+0.02%) ⬆️
#single 41.72% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 89.08% <ø> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f886139...ec25028. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25647 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25647      +/-   ##
==========================================
+ Coverage   91.26%   91.29%   +0.02%     
==========================================
  Files         173      173              
  Lines       52968    52948      -20     
==========================================
- Hits        48340    48337       -3     
+ Misses       4628     4611      -17
Flag Coverage Δ
#multiple 89.86% <ø> (+0.02%) ⬆️
#single 41.72% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 89.08% <ø> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f886139...ec25028. Read the comment docs.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sparse failure is being fixed elsewhere.

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone Mar 11, 2019
@jorisvandenbossche jorisvandenbossche merged commit 99bffa2 into pandas-dev:master Mar 11, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

@WillAyd WillAyd deleted the debug-cleanup branch March 11, 2019 17:38
thoo added a commit to thoo/pandas that referenced this pull request Mar 11, 2019
* upstream/master: (110 commits)
  DOC: hardcode contributors for 0.24.x releases (pandas-dev#25662)
  DOC: restore toctree maxdepth (pandas-dev#25134)
  BUG: Redefine IndexOpsMixin.size, fix pandas-dev#25580. (pandas-dev#25584)
  BUG: to_csv line endings with compression (pandas-dev#25625)
  DOC: file obj for to_csv must be newline='' (pandas-dev#25624)
  Suppress incorrect warning in nargsort for timezone-aware DatetimeIndex (pandas-dev#25629)
  TST: fix incorrect sparse test (now failing on scipy master) (pandas-dev#25653)
  CLN: Removed debugging code (pandas-dev#25647)
  DOC: require Return section only if return is not None nor commentary (pandas-dev#25008)
  DOC:Remove hard-coded examples from _flex_doc_SERIES (pandas-dev#24589) (pandas-dev#25524)
  TST: xref pandas-dev#25630 (pandas-dev#25643)
  BUG: Fix pandas-dev#25481 by fixing the error message in TypeError (pandas-dev#25540)
  Fixturize tests/frame/test_mutate_columns.py (pandas-dev#25642)
  Fixturize tests/frame/test_join.py (pandas-dev#25639)
  Fixturize tests/frame/test_combine_concat.py (pandas-dev#25634)
  Fixturize tests/frame/test_asof.py (pandas-dev#25628)
  BUG: Fix user-facing AssertionError with to_html (pandas-dev#25608) (pandas-dev#25620)
  DOC: resolve all GL03 docstring validation errors (pandas-dev#25525)
  TST: failing wheel building on PY2 and old numpy (pandas-dev#25631)
  DOC: Remove makePanel from docs (pandas-dev#25609) (pandas-dev#25612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants