Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json normalize nan support #25619

Merged
merged 12 commits into from
Mar 13, 2019
Merged

Json normalize nan support #25619

merged 12 commits into from
Mar 13, 2019

Conversation

antoineviscardi
Copy link
Contributor

@gfyoung gfyoung added IO JSON read_json, to_json, json_normalize Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Mar 9, 2019
@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #25619 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25619   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.71% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 96.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976a2db...a24a213. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 9, 2019 •
edited
Loading

Codecov Report

Merging #25619 into master will decrease coverage by 49.51%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25619       +/-   ##
===========================================
- Coverage   91.25%   41.73%   -49.52%     
===========================================
  Files         172      172               
  Lines       52963    52963               
===========================================
- Hits        48330    22106    -26224     
- Misses       4633    30857    +26224
Flag Coverage Δ
#multiple ?
#single 41.73% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 8.16% <0%> (-88.78%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86879ac...57e5b29. Read the comment docs.

WillAyd
WillAyd requested changes Mar 9, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also refactor test_json_normalize_errors to use the new fixture that you've created?

jreback
jreback requested changes Mar 10, 2019
View reviewed changes
WillAyd
WillAyd requested changes Mar 10, 2019
View reviewed changes
WillAyd
WillAyd approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

jreback
jreback requested changes Mar 10, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. small comments, ping on green.

@jreback jreback added this to the 0.25.0 milestone Mar 10, 2019
jreback
jreback requested changes Mar 12, 2019
View reviewed changes
@jreback
Copy link
Contributor

jreback commented Mar 13, 2019

can you merge master and update; ping on green.

@codecov
Copy link

codecov bot commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #25619 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25619   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         172      172           
  Lines       52963    52963           
=======================================
  Hits        48330    48330           
  Misses       4633     4633
Flag Coverage Δ
#multiple 89.82% <100%> (ø) ⬆️
#single 41.73% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 96.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86879ac...57e5b29. Read the comment docs.

@jreback jreback merged commit dcf7fce into pandas-dev:master Mar 13, 2019
@jreback
Copy link
Contributor

jreback commented Mar 13, 2019

thanks @antoineviscardi

@antoineviscardi antoineviscardi deleted the json-normalize-nan-support branch March 13, 2019 18:37
sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019
@sighingnow
Merge branch 'master' into fix-25587
4095c8c 
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO JSON read_json, to_json, json_normalize Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Literal nan string stored in dataframe using json_normalize for null value in string metadata column
4 participants
@antoineviscardi @jreback @WillAyd @gfyoung