Fix import format at pandas/tests/io/plotting directory #24580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
requested changes
Jan 3, 2019
|
|
||
| converter = pytest.importorskip('pandas.plotting._converter') | ||
| from pandas.plotting import (register_matplotlib_converters, | ||
| deregister_matplotlib_converters) |
There was a problem hiding this comment.
I imagine you will need to use an isort:skip here
Codecov Report
@@ Coverage Diff @@
## master #24580 +/- ##
===========================================
+ Coverage 43.05% 92.36% +49.31%
===========================================
Files 166 166
Lines 52490 52494 +4
===========================================
+ Hits 22598 48485 +25887
+ Misses 29892 4009 -25883
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24580 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52490 52490
=======================================
Hits 48493 48493
Misses 3997 3997
Continue to review full report at Codecov.
|
|
@jreback passed |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffRan
isort --recursive pandas/tests/io/plottingand then checked imports usingisort --recursive --check-only pandas/tests/io/plotting