Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run isort at pandas/tests/io #24532

Merged
merged 10 commits into from
Jan 2, 2019
Merged

Run isort at pandas/tests/io #24532

merged 10 commits into from
Jan 2, 2019

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Jan 1, 2019

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 1, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 1, 2019
@thoo thoo changed the title flake8 and import issue Run isort at pandas/tests/io Jan 1, 2019
@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

merge master

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24532   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52427    52427           
=======================================
  Hits        16714    16714           
  Misses      35713    35713
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9284a2...41ee93e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24532 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24532   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         166      166           
  Lines       52440    52440           
=======================================
  Hits        48416    48416           
  Misses       4024     4024
Flag Coverage Δ
#multiple 90.75% <100%> (ø) ⬆️
#single 43.01% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/style.py 96.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71efe61...8df2ab4. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

need a merge master

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

can you merge again and something failng

thoo added 3 commits January 1, 2019 15:24
* upstream/master:
  Make DTI[tz]._values and Series[tz]._values return DTA (pandas-dev#24534)
  CLN: Refactor some sorting code in Index set operations (pandas-dev#24533)
  Run isort (pandas-dev#24530)
  CI: fix db usage in CI (pandas-dev#24529)
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

@thoo can you see if can get passing

* upstream/master:
  implement fillna from 24024, with fixes and tests (pandas-dev#24536)
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

lgtm. ping on green.

@jreback jreback merged commit 48dad14 into pandas-dev:master Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

thanks @thoo

@thoo thoo deleted the isort-io branch January 2, 2019 20:25
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants