TST: Continue collecting arithmetic tests #22559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22559 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50787 50787
=======================================
Hits 46745 46745
Misses 4042 4042
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
| df > ts | ||
| with pytest.raises(TypeError): | ||
| df < ts | ||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
shouldn't these be in test_datetime64?
There was a problem hiding this comment.
No, this is specifically testing that the numeric-dtypes are correctly handling the presence of datetime64-dtype, not vice-versa.
| ts < df | ||
| with pytest.raises(TypeError): | ||
| ts > df | ||
|
|
There was a problem hiding this comment.
can you add for tz as well (use the fixture)
There was a problem hiding this comment.
Sure; follow-up. This PR is pretty specifically only-moving.
| @@ -180,3 +180,36 @@ def test_series_with_dtype_radd_timedelta(self, dtype): | |||
|
|
|||
| result = ser + pd.Timedelta('3 days') | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
There was a problem hiding this comment.
would move these to test_datetime64 (maybe rename that to test_datetime)
There was a problem hiding this comment.
These are mixed-type; it's pretty specifically the object-dtyped Index/Series/Column that these tests are addressing.
| b = pd.Series(np.random.randn(5)) | ||
| b.name = pd.Timestamp('2000-01-01') | ||
| tm.assert_series_equal(a / b, 1 / (b / a)) | ||
|
|
||
|
|
||
| # ------------------------------------------------------------------ | ||
| # Numeric dtypes Arithmetic with Timedelta Scalar |
There was a problem hiding this comment.
are there timedelta tests that should be moved (ok for followup, just indicate)
There was a problem hiding this comment.
Those should all be in test_arithmetic, which this PR moves to arithmetic.test_timedelta64
|
Blocker for some parameterization/deduplication |
|
thanks! |
This is split off of #22350, which may have been too ambitious.
tests/test_arithmetic.py is moved to tests/arithmetic/test_timedelta64.py. Aside from being moved it is untouched.