Drop redundant TestLocale #22349
Merged
Drop redundant TestLocale #22349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the `TestLocaleUtils` class in `tests/util/test_util.py` https://github.com/pandas-dev/pandas/blob/master/pandas/tests/util/test_util.py#L421 which is more comprehensive and includes `test_get_locales` which is functionally identical.
gfyoung
added
Testing
|
Should we move the reference to #9744 over to |
|
@ginggs : Yeah, why not. Let's do that. |
Codecov Report
@@ Coverage Diff @@
## master #22349 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 169 169
Lines 50709 50709
=======================================
Hits 46679 46679
Misses 4030 4030
Continue to review full report at Codecov.
|
|
Hmm I suppose the only difference here is that the previous test was only skipped on 32 bit windows but assumedly held for 64 bit. With the refactor it is skipped for both. My knowledge of Windows locale is nil, but any concern about the change here for 64 bit Windows? Maybe the target class' skip decorator should only apply to 32 bit Windows? |
|
Apparently |
|
thanks! |
Moons08
pushed a commit
to Moons08/pandas
that referenced
this pull request
Aug 17, 2018
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Aug 18, 2018
commit b29dfc6 Author: Tom Augspurger <[email protected]> Date: Thu Aug 16 10:45:38 2018 -0500 Support NDFrame.shift with EAs Uses take internally. Closes pandas-dev#22386 commit b5d81cf Author: William Ayd <[email protected]> Date: Thu Aug 16 03:54:18 2018 -0700 Bump pytest (pandas-dev#22320) commit f07a790 Author: jbrockmendel <[email protected]> Date: Thu Aug 16 03:46:58 2018 -0700 Make more of numpy_helper unnecessary (pandas-dev#22344) commit 7b80d4d Author: Graham Inggs <[email protected]> Date: Thu Aug 16 12:43:02 2018 +0200 Drop redundant TestLocale (pandas-dev#22349) commit 6bcfc46 Author: Matthew Roeschke <[email protected]> Date: Thu Aug 16 03:32:31 2018 -0700 Fix failing dateutil test (pandas-dev#22354) commit 86e8f23 Author: jbrockmendel <[email protected]> Date: Thu Aug 16 03:08:09 2018 -0700 remove last cython: nprofile comments (pandas-dev#22371) commit 70e6f7c Author: Joris Van den Bossche <[email protected]> Date: Wed Aug 15 18:09:50 2018 +0200 DOC: edit docstring example to prevent segfault (pandas-dev#21824) (pandas-dev#22368)
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Aug 18, 2018
commit c4b0b97 Author: Tom Augspurger <[email protected]> Date: Thu Aug 16 14:36:39 2018 -0500 Slice based commit c980035 Author: Tom Augspurger <[email protected]> Date: Thu Aug 16 14:20:21 2018 -0500 Updated commit b29dfc6 Author: Tom Augspurger <[email protected]> Date: Thu Aug 16 10:45:38 2018 -0500 Support NDFrame.shift with EAs Uses take internally. Closes pandas-dev#22386 commit b5d81cf Author: William Ayd <[email protected]> Date: Thu Aug 16 03:54:18 2018 -0700 Bump pytest (pandas-dev#22320) commit f07a790 Author: jbrockmendel <[email protected]> Date: Thu Aug 16 03:46:58 2018 -0700 Make more of numpy_helper unnecessary (pandas-dev#22344) commit 7b80d4d Author: Graham Inggs <[email protected]> Date: Thu Aug 16 12:43:02 2018 +0200 Drop redundant TestLocale (pandas-dev#22349) commit 6bcfc46 Author: Matthew Roeschke <[email protected]> Date: Thu Aug 16 03:32:31 2018 -0700 Fix failing dateutil test (pandas-dev#22354) commit 86e8f23 Author: jbrockmendel <[email protected]> Date: Thu Aug 16 03:08:09 2018 -0700 remove last cython: nprofile comments (pandas-dev#22371) commit 70e6f7c Author: Joris Van den Bossche <[email protected]> Date: Wed Aug 15 18:09:50 2018 +0200 DOC: edit docstring example to prevent segfault (pandas-dev#21824) (pandas-dev#22368)
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
TestLocaleUtilsclass intests/util/test_util.pyhttps://github.com/pandas-dev/pandas/blob/master/pandas/tests/util/test_util.py#L421
which is more comprehensive and includes
test_get_localeswhich is functionally identical.git diff upstream/master -u -- "*.py" | flake8 --diff