[CLN] More Misc Cleanups in _libs #22287
Conversation
pandas/_libs/lib.pyx
Outdated
| @@ -647,7 +646,7 @@ def row_bool_subset(ndarray[float64_t, ndim=2] values, | |||
| out[pos, j] = values[i, j] | |||
| pos += 1 | |||
|
|
|||
| return out | |||
| return out.base # `.base` to access underlying np.ndarray | |||
There was a problem hiding this comment.
I know elsewhere we do np.asarray(<memoryview>) - are those equivalent?
There was a problem hiding this comment.
Very close to equivalent. It's a bit roundabout.
Above out is typed as a float64_t[:, :] memoryview, but then instantiated with
out = np.empty((mask.sum(), k), dtype=np.float64)
In executing that line, cython creates the numpy array, then casts it as a memoryview out, and attaches the original ndarray as out.base. So out.base is an attribute lookup to return an existing np.ndarray.
The performance penalty to np.asarray must be tiny; it might be worth it to do it that way to avoid confusion.
There was a problem hiding this comment.
ahh yes, can we change these
Codecov Report
@@ Coverage Diff @@
## master #22287 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 169 169
Lines 50709 50709
=======================================
Hits 46679 46679
Misses 4030 4030
Continue to review full report at Codecov.
|
gfyoung
added
Internals
No, just periodically reading through them. My vague plan for achieving linting is to get the code (at least some pyx modules) "close enough" to valid python to trick the linter. |
pandas/_libs/lib.pyx
Outdated
| @@ -329,10 +329,10 @@ def fast_zip(list ndarrays): | |||
| Py_INCREF(val) | |||
| PyArray_ITER_NEXT(it) | |||
|
|
|||
| return result | |||
| return result.base # `.base` to access underlying np.ndarray | |||
There was a problem hiding this comment.
can you change these in this PR
|
Had to revert some edits to fix persistent ResourceWarning in one Travis environment. Will try to narrow down the culprit in the next pass. |
|
Ping (got “LGTM” a few days ago) |
|
thanks |
cpdef --> cdef in a few cases
modernize string formatting
modernize for loop syntax
Should be orthogonal to other outstanding PR(s)