Collect datetime64 and PeriodDtype arithmetic tests #22237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22237 +/- ##
==========================================
+ Coverage 92.06% 92.07% +<.01%
==========================================
Files 169 169
Lines 50698 50698
==========================================
+ Hits 46676 46680 +4
+ Misses 4022 4018 -4
Continue to review full report at Codecov.
|
jreback
added
Testing
|
thanks. thought was moving maybe ought to move some of the fixtures to the top-level conftest |
That's coming up, but I decided to wait on that until after #22163 to avoid merge conflicts |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested, these are split by dtype in a new tests/arithmetic directory.
Started parametrizing a few of these over
boxclasses, but for the most part this is just collecting tests from their existing locations. There is going to be a lot of parametrization and de-duplication coming up.Holding off on moving the existing timedelta64-dtype tests until #22163 is handled to avoid merge conflict.