Centralize m8[ns] Arithmetic Tests #22118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22118 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 170 170
Lines 50690 50690
=======================================
Hits 46672 46672
Misses 4018 4018
Continue to review full report at Codecov.
|
jreback
added
Testing
I've been thinking about this too. So far this file is all timedelta64[ns], so that's easy at least. I'll split it in an upcoming pass. |
great, yah this will quickly explode otherwise i think. |
| @@ -2,14 +2,30 @@ | |||
| # Arithmetc tests for DataFrame/Series/Index/Array classes that should | |||
There was a problem hiding this comment.
maybe add comments in the individual test_arithmetic that point back to this series (so future tests are put appropriately), can be in the future
| # ------------------------------------------------------------------ | ||
| # Fixtures | ||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
ideally centralize / cleanup fixtures, future pass ok
| @@ -53,7 +69,7 @@ def test_index_mul_timedelta(self, scalar_td, index, box): | |||
| commute = scalar_td * index | |||
| tm.assert_equal(commute, expected) | |||
|
|
|||
| @pytest.mark.parametrize('box', [pd.Index, pd.Series, pd.DataFrame]) | |||
| @pytest.mark.parametrize('box', [pd.Index, Series, pd.DataFrame]) | |||
There was a problem hiding this comment.
FYI this needs a fixture (future ok)
|
thanks. a few comments on future things to do. |
There are a bunch still left in the TDI tests, but the diff is already pretty big as it is.
A ton of
DataFrametests are xfailed here. Most of these will be fixed by the follow-up to (#22068 + #22074).xfails are made strict so that we get alerted when they are fixed. Several existing xfails are removed since they have been XPASSing for a while.
@jreback I know you're going to want to make fixtures for a bunch of things. I agree, but think that will be 19.6x easier after fixing some of the xfails. Also this is step 2 of a many-step process and in general I'd prefer to do cleanup after getting more stuff in place.