Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Return Structure for Rolling Apply #20984

Merged
merged 5 commits into from
May 9, 2018

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented May 9, 2018

With the changes made in #20949 it appears possible to fix this bug by suppressing a catch block that was internal to Rolling's _apply. I'm not sure what the purpose of this catch as it essentially allows values to bypass the applied function...Only one test broke on removal which looked wrong anyway, so I updated it as such

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

can u add a whatsnew note 0.23 ok

@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #20984 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20984      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files         153      153              
  Lines       49490    49486       -4     
==========================================
- Hits        45443    45439       -4     
  Misses       4047     4047
Flag Coverage Δ
#multiple 90.21% <100%> (-0.01%) ⬇️
#single 41.85% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/window.py 96.27% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f07b2...878e640. Read the comment docs.

@jreback jreback added Bug Groupby Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 9, 2018
@jreback jreback added this to the 0.23.0 milestone May 9, 2018
@jreback jreback merged commit 21ee836 into pandas-dev:master May 9, 2018
@jreback
Copy link
Contributor

jreback commented May 9, 2018

thanks!

@WillAyd WillAyd deleted the roll-grp-reset branch May 9, 2018 10:25
@WillAyd WillAyd added the Window rolling, ewma, expanding label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Reshaping Concat, Merge/Join, Stack/Unstack, Explode Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling groupby should not maintain the by column in the resulting DataFrame
2 participants