Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Allow overwriting object columns with EAs #20556

Merged
merged 1 commit into from
Mar 31, 2018
Merged

BUG: Allow overwriting object columns with EAs #20556

merged 1 commit into from
Mar 31, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #20555

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 30, 2018
TomAugspurger added a commit to TomAugspurger/intake-pcap that referenced this pull request Mar 30, 2018
@TomAugspurger
[WIP]: Added cyberpandas support
f39e24c 
* Updated example for change in import
* Added dependency
* refactored dataframe column check to assert dtypes

Waiting on pandas-dev/pandas#20556
@TomAugspurger TomAugspurger mentioned this pull request Mar 30, 2018
Merged
@jreback jreback added Bug ExtensionArray Extending pandas with custom dtypes or arrays. labels Mar 30, 2018
@codecov
Copy link

codecov bot commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #20556 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20556      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         152      152              
  Lines       49259    49259              
==========================================
- Hits        45229    45227       -2     
- Misses       4030     4032       +2
Flag Coverage Δ
#multiple 90.2% <ø> (-0.01%) ⬇️
#single 41.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals.py 95.53% <ø> (ø) ⬆️
pandas/util/testing.py 84.52% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b4a81...3077a10. Read the comment docs.

@jreback jreback merged commit f71cd9a into pandas-dev:master Mar 31, 2018
@jreback
Copy link
Contributor

jreback commented Mar 31, 2018

thanks!

kornilova203 pushed a commit to kornilova203/pandas that referenced this pull request Apr 23, 2018
@TomAugspurger @kornilova203
BUG: Allow overwriting object columns with EAs (pandas-dev#20556)
82cf120 
Closes pandas-dev#20555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Bug ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jreback @gfyoung