BUG: raise error when setting cached properties #20487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug I introduced myself some time ago in #19991. Apparently the object needs to explicitly raise in the
__set__
method, otherwise the property is assumed to be settable:is_unique
is a cached property, didn't raise anymore on master (see above), in contrast to normal propertyis_monotonic
.This patch ensures also cached properties have the same error.