Fix Index mul/div ops with Series, closes #19080, #19042 #19253
Conversation
jreback
added
Indexing
|
lgtm. pls add a whatsnew note, bug fix / conversion. in generall anything that is user facing needs a whatsnew note. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #19253 +/- ##
==========================================
+ Coverage 91.56% 91.56% +<.01%
==========================================
Files 148 148
Lines 48856 48861 +5
==========================================
+ Hits 44733 44738 +5
Misses 4123 4123
Continue to review full report at Codecov.
|
| @@ -423,6 +423,9 @@ Conversion | |||
| - Bug in :class:`WeekOfMonth` and :class:`LastWeekOfMonth` where default keyword arguments for constructor raised ``ValueError`` (:issue:`19142`) | |||
| - Bug in localization of a naive, datetime string in a ``Series`` constructor with a ``datetime64[ns, tz]`` dtype (:issue:`174151`) | |||
| - :func:`Timestamp.replace` will now handle Daylight Savings transitions gracefully (:issue:`18319`) | |||
| - Bug in :class:`Index` multiplication and division methods where operating with a ``Series`` would return an ``Index`` object instead of a ``Series`` object (:issue:`19042`) | |||
There was a problem hiding this comment.
in another PR, pls separate out all of the ops changes into a separate sub-section of Bug Fixes (as I think we have a lot), call it Operations
There was a problem hiding this comment.
Sure. All 4 current entries in the Numeric subsection could plausibly belong in Operations. Move them or leave them be?
There was a problem hiding this comment.
Also a) also move comparison method changes or just arithmetic methods and b) also move offset arithmetic, or just Series/Index?
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff