Fix pd.NaT - Series #19251
Merged
Fix pd.NaT - Series #19251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 15, 2018
| @@ -386,9 +386,7 @@ Conversion | |||
| - Bug in :class:`WeekOfMonth` and :class:`LastWeekOfMonth` where default keyword arguments for constructor raised ``ValueError`` (:issue:`19142`) | |||
| - Bug in localization of a naive, datetime string in a ``Series`` constructor with a ``datetime64[ns, tz]`` dtype (:issue:`174151`) | |||
| - :func:`Timestamp.replace` will now handle Daylight Savings transitions gracefully (:issue:`18319`) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
pls leave white space this is on purpose to avoid conflicts
jreback
added
Datetime
|
#19139 merged, so rebase and remove xfails. |
Codecov Report
@@ Coverage Diff @@
## master #19251 +/- ##
=========================================
Coverage ? 91.54%
=========================================
Files ? 147
Lines ? 48825
Branches ? 0
=========================================
Hits ? 44699
Misses ? 4126
Partials ? 0
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 16, 2018
|
lgtm. ping on green. |
|
Ping |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will be added after #19139 is merged, since largely that will involve removing an "xfail" from tests that already exist there.
git diff upstream/master -u -- "*.py" | flake8 --diff