BUG: Fix tz-aware DatetimeIndex +/- TimedeltaIndex/timedelta64 array #18653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 6, 2017
| tdi = pd.timedelta_range('0 days', periods=10) | ||
| expected = pd.date_range('2017-01-01', periods=10, tz=tz) | ||
|
|
||
| result = dti + tdi |
| tdi = pd.timedelta_range('0 days', periods=10) | ||
| expected = pd.date_range('2017-01-01', periods=10, tz=tz, freq='-1D') | ||
|
|
||
| result = dti - tdi |
There was a problem hiding this comment.
test that the reverse ops raise
jschendel
force-pushed
the
tz-aware-add-tdi
branch
from
1e5807e to
cc6b19b
Compare
Codecov Report
@@ Coverage Diff @@
## master #18653 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 153 153
Lines 51221 51223 +2
==========================================
- Hits 46917 46909 -8
- Misses 4304 4314 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18653 +/- ##
==========================================
+ Coverage 91.57% 91.57% +<.01%
==========================================
Files 153 153
Lines 51210 51212 +2
==========================================
+ Hits 46894 46899 +5
+ Misses 4316 4313 -3
Continue to review full report at Codecov.
|
jschendel
force-pushed
the
tz-aware-add-tdi
branch
from
cc6b19b to
2a665c0
Compare
jreback
approved these changes
Dec 7, 2017
|
thanks @jschendel very nice; keep em coming! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAdded the whatsnew entry under 0.22.0, but could possibly go under 0.21.1. This PR is a prereq for #18558.