Move fields functions out of the way #17770

jbrockmendel · 2017-10-03T22:13:45Z

Notes:

The only usage in tslib of get_date_name_field is for Timestamp.weekday and can be simplified with a more direct call.
Several of the functions from tslibs.fields imported into tslib are unused. Updating the external imports to use the new locations is for a follow-up.
There is some flake8 cleanup to be done in the the new tslibs.fields, but that is being saved for a follow-up. For now this is just cut/paste.
get_start_end_field will be largely unnecessary if/when the suggestion to deprecate Timestamp.freq in DEPR: remove freq attribute of Timestamp? #15146 is adopted.
closes #xxxx
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2017-10-04T02:22:21Z

Hello @jbrockmendel! Thanks for updating the PR.

In the file setup.py, following are the PEP8 issues :

Line 492:80: E501 line too long (82 > 79 characters)
Line 493:80: E501 line too long (92 > 79 characters)

Comment last updated on October 04, 2017 at 14:36 Hours UTC

codecov · 2017-10-04T05:50:04Z

Codecov Report

Merging #17770 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17770      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       49872    49872              
==========================================
- Hits        45514    45505       -9     
- Misses       4358     4367       +9

Flag	Coverage Δ
#multiple	`89.04% <ø> (ø)`	⬆️
#single	`40.24% <ø> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.73% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81694dc...7b12b5a. Read the comment docs.

codecov · 2017-10-04T05:50:06Z

Codecov Report

Merging #17770 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17770      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       49872    49872              
==========================================
- Hits        45514    45505       -9     
- Misses       4358     4367       +9

Flag	Coverage Δ
#multiple	`89.04% <ø> (ø)`	⬆️
#single	`40.24% <ø> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.73% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81694dc...7b12b5a. Read the comment docs.

codecov · 2017-10-04T05:50:12Z

Codecov Report

Merging #17770 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #17770      +/-   ##
==========================================
- Coverage   91.26%   91.22%   -0.04%     
==========================================
  Files         163      163              
  Lines       49872    49917      +45     
==========================================
+ Hits        45514    45536      +22     
- Misses       4358     4381      +23

Flag	Coverage Δ
#multiple	`89.02% <100%> (-0.02%)`	⬇️
#single	`40.24% <50%> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/period.py	`92.78% <100%> (+0.01%)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/indexing.py	`93% <0%> (-0.98%)`	⬇️
pandas/core/frame.py	`97.73% <0%> (-0.1%)`	⬇️
pandas/core/generic.py	`92.1% <0%> (-0.03%)`	⬇️
pandas/core/common.py	`91.42% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81694dc...0e9e1e5. Read the comment docs.

jreback

lgtm. some comments. ping on green.

jreback · 2017-10-04T10:28:35Z

pandas/_libs/tslibs/fields.pyx

+from numpy cimport ndarray, int64_t, int32_t, int8_t
+np.import_array()
+
+cdef int64_t NPY_NAT = np.datetime64('NaT').astype(np.int64)


use util.get_nat(), don't change the incantation

Had hoped to avoid dependency; changing.

jreback · 2017-10-04T10:29:59Z

pandas/_libs/tslibs/fields.pyx

+    return days_per_month_table[is_leapyear(dts.year)][dts.month -1]
+
+
+cpdef _isleapyear_arr(ndarray years):


can de-privatize

jreback · 2017-10-04T10:30:34Z

pandas/_libs/tslibs/fields.pyx

+    cdef:
+        ndarray[int8_t] out
+
+    # to make NaT result as False


I think ok to remove this comment (instead add a doc-string)

jreback · 2017-10-04T10:32:31Z

get_start_end_field will be largely unnecessary if/when the suggestion to deprecate Timestamp.freq in #15146 is adopted.

I think this would be a difficult change FYI

jreback · 2017-10-04T23:53:54Z

thanks!

jbrockmendel added 4 commits October 2, 2017 10:25

Move fields functions out of the way

7ff41db

troubleshoot ci failure

dbf4c75

dummy commit (that fixes a flake8 complaint) to force CI

7d8f421

add sources to setup to try to fix appveyor build

e5f77e4

jbrockmendel added 2 commits October 3, 2017 19:36

flake8 whitespace fixup

9aa1eb3

fixup typo

7b12b5a

jreback requested changes Oct 4, 2017

View reviewed changes

jreback added Datetime Datetime data dtype Clean labels Oct 4, 2017

reviewer comments

0e9e1e5

jreback added this to the 0.21.0 milestone Oct 4, 2017

jreback approved these changes Oct 4, 2017

View reviewed changes

jreback merged commit a26afca into pandas-dev:master Oct 4, 2017

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017

Move fields functions out of the way (pandas-dev#17770)

48d4c77

jbrockmendel deleted the tslibs-fields branch October 30, 2017 16:22

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

Move fields functions out of the way (pandas-dev#17770)

f9eeb89

No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

Move fields functions out of the way (pandas-dev#17770)

36307ff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move fields functions out of the way #17770

Move fields functions out of the way #17770

jbrockmendel commented Oct 3, 2017

pep8speaks commented Oct 4, 2017 •

edited

Loading

codecov bot commented Oct 4, 2017

codecov bot commented Oct 4, 2017

codecov bot commented Oct 4, 2017 •

edited

Loading

jreback left a comment

jreback Oct 4, 2017

jbrockmendel Oct 4, 2017

jreback Oct 4, 2017

jreback Oct 4, 2017

jreback commented Oct 4, 2017

jreback commented Oct 4, 2017

		return days_per_month_table[is_leapyear(dts.year)][dts.month -1]


		cpdef _isleapyear_arr(ndarray years):

Move fields functions out of the way #17770

Move fields functions out of the way #17770

Conversation

jbrockmendel commented Oct 3, 2017

pep8speaks commented Oct 4, 2017 • edited Loading

Comment last updated on October 04, 2017 at 14:36 Hours UTC

codecov bot commented Oct 4, 2017

Codecov Report

codecov bot commented Oct 4, 2017

Codecov Report

codecov bot commented Oct 4, 2017 • edited Loading

Codecov Report

jreback left a comment

Choose a reason for hiding this comment

jreback Oct 4, 2017

Choose a reason for hiding this comment

jbrockmendel Oct 4, 2017

Choose a reason for hiding this comment

jreback Oct 4, 2017

Choose a reason for hiding this comment

jreback Oct 4, 2017

Choose a reason for hiding this comment

jreback commented Oct 4, 2017

jreback commented Oct 4, 2017

pep8speaks commented Oct 4, 2017 •

edited

Loading

codecov bot commented Oct 4, 2017 •

edited

Loading