-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fixed issue with mixed type groupby aggregate #17003
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4c9e32d
BUG: fixed issue with mixed type groupby aggregate
a58de54
Addressing review comments from PR issue16916
dbbb0d4
Merge branch 'master' into issue16916
7b24ee1
Merge branch 'master' of https://github.com/pandas-dev/pandas into is…
a7a20d5
DOC: Fix incorrect merge conflict
34ca8d8
used safe_sort in groupby.py
ba57c26
Merge branch 'master' of https://github.com/pandas-dev/pandas into is…
b634bc9
re-added bug fix at line 281
89c585b
DOC: Correct release notes
ElDeveloper 0391dfd
Merge pull request #1 from ElDeveloper/issue16916
4a2dfba
Merge branch 'master' into issue16916
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -892,3 +892,17 @@ def test_sum_uint64_overflow(self): | |
expected.index.name = 0 | ||
result = df.groupby(0).sum() | ||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_mixed_type_grouping(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Refer the issue number beneath the function definition (e.g. "see gh-19616") |
||
# see gh-19616 | ||
expected = pd.DataFrame(data=[[[1, 1], [2, 2], [3, 3]], | ||
[[1, 1], [2, 2], [3, 3]]], | ||
columns=['X', 'Y', 'Z'], | ||
index=pd.Index(data=[2, 'g1'], | ||
name='grouping')) | ||
|
||
df = pd.DataFrame(data=[[1, 2, 3], [1, 2, 3], [1, 2, 3], [1, 2, 3]], | ||
columns=list('XYZ'), index=list('qwer')) | ||
df['grouping'] = ['g1', 'g1', 2, 2] | ||
result = df.groupby('grouping').aggregate(lambda x: x.tolist()) | ||
tm.assert_frame_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to 0.22.0