-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option Page Typos #16421
Option Page Typos #16421
Conversation
@andymaheshw thanks! keep em coming! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, for the rest looks good
@@ -28,7 +28,7 @@ You can get/set options directly as attributes of the top-level ``options`` attr | |||
pd.options.display.max_rows = 999 | |||
pd.options.display.max_rows | |||
|
|||
There is also an API composed of 5 relevant functions, available directly from the ``pandas`` | |||
The API is composed of 5 relevant functions, available directly from the ``pandas`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "there is also" does give a bit more the notion of "next to the possibility of directly getting/setting options onpd.options. ..
, you also have some functions to work with them". So maybe "Additionally, the ..", or "the api is further composed ..." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, ignore this :-) as Tom already merged (not that important)
Codecov Report
@@ Coverage Diff @@
## master #16421 +/- ##
==========================================
+ Coverage 90.42% 90.42% +<.01%
==========================================
Files 161 161
Lines 51023 51023
==========================================
+ Hits 46137 46138 +1
+ Misses 4886 4885 -1
Continue to review full report at Codecov.
|
* capitalization update * update * undoing capitalization
* capitalization update * update * undoing capitalization
Problem description
There are typos on this page and one confusing sentence. Trying to learn the workflow.