BUG: resample with tz-aware: Values falls after last bin #15555
Conversation
|
jreback, would you like me to add tests for this change ? |
|
tests! always and a whatsnew note please. |
jreback
changed the title
|
committed a test and wrote a whatsnew note. |
|
I understand why the checks failed, I will commit a fix |
|
@jreback is it ok to change already existing tests in order to make my change pass them ? |
|
you need to prove that a current test is wrong in order to change it |
| def test_resample_tz_aware_bug_15549(self): | ||
| index = pd.DatetimeIndex([1450137600000000000, 1474059600000000000], tz='UTC').tz_convert('America/Chicago') | ||
| df = pd.DataFrame([1, 2], index=index) | ||
| df.resample('12h', closed='right', label='right').last().ffill() |
There was a problem hiding this comment.
result = df.resample(.......)
expected = ....
tm.assert_frame_equal(result, expected)
add a comment with the issue number as a comment (and not in the test name)
There was a problem hiding this comment.
agree, I will fix it. I just used the same notation as in the test above. thought it's a common thing
| @@ -2670,6 +2670,11 @@ def test_resample_weekly_bug_1726(self): | |||
| # it works! | |||
| df.resample('W-MON', closed='left', label='left').first() | |||
|
|
|||
| def test_resample_tz_aware_bug_15549(self): | |||
| index = pd.DatetimeIndex([1450137600000000000, 1474059600000000000], tz='UTC').tz_convert('America/Chicago') | |||
There was a problem hiding this comment.
this line is going to be too long for linting.
There was a problem hiding this comment.
understood, I will change it
|
I think you need to compute the range edges with the tz intact. I think it is mishandling when it has an ambiguous datetime. Then constructing the tz should be ok. |
|
got it, let me try to use your approach |
|
@ahcub yeah this seemingly trivial change is actually hard. there have been lots of fixes (for various reasons) thru the years. good news is the test suite is quite comprehensive here :> |
|
can you rebase / update |
|
I will close it for now and restore it when I get back to it |
|
@ahcub ok sure. though pls come back when you can! thanks! |
git diff upstream/master | flake8 --diff7:00 19:00 7:00 19:00
instead of
00:00 12:00 00:00 12:00