TST: Groupby.groups of datetimeindex (#11442) #14952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.65% (diff: 100%)@@ master #14952 diff @@
==========================================
Files 144 144
Lines 51030 51030
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43199 43198 -1
- Misses 7831 7832 +1
Partials 0 0
|
jreback
added
Groupby
Testing
jreback
reviewed
Dec 22, 2016
| result = df.groupby(level='date').groups | ||
| dates = ['2015-01-05', '2015-01-04', '2015-01-03', | ||
| '2015-01-02', '2015-01-01'] | ||
| expected = {pd.Timestamp(date): pd.DatetimeIndex([date], name='date') |
There was a problem hiding this comment.
add the .get_group call as well here. ping on green.
add get_group test
mroeschke
force-pushed
the
test_11442
branch
from
b7403bf to
6c16211
Compare
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
…4952) add get_group test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffDoesn't look a PR in 0.19.2 and 0.20.0 addressed this, but it works on master 0.19.1