Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In gbq.to_gbq allow the DataFrame column order to differ from schema #14202

Closed

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 11, 2016

@parthea parthea force-pushed the gbq-verify-schema-less-scrict branch from c37ff46 to 7e6a073 Compare September 11, 2016 16:33
@parthea parthea changed the title In gbq.to_gbq allow the DataFrame column order to differ from df In gbq.to_gbq allow the DataFrame column order to differ from schema Sep 11, 2016
@jreback jreback added Error Reporting Incorrect or improved errors from pandas IO Google labels Sep 11, 2016
@jreback
Copy link
Contributor

jreback commented Sep 11, 2016

lgtm. ping on green.

@jreback jreback added this to the 0.19.0 milestone Sep 11, 2016
@parthea
Copy link
Contributor Author

parthea commented Sep 11, 2016

All gbq tests passed with my credentials.

Only 1 test failed on pydata/pandas Travis-ci . At first glance, the failure appears to be unrelated to my changes.

======================================================================
FAIL: test_sum (pandas.tests.frame.test_analytics.TestDataFrameAnalytics)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pydata/pandas/pandas/tests/frame/test_analytics.py", line 420, in test_sum
    check_less_precise=True)
  File "/home/travis/build/pydata/pandas/pandas/tests/frame/test_analytics.py", line 897, in _check_stat_op
    check_less_precise=check_less_precise)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 1181, in assert_series_equal
    obj='{0}'.format(obj))
  File "testing.pyx", line 59, in pandas._testing.assert_almost_equal (pandas/src/testing.c:3262)
  File "testing.pyx", line 173, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2590)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 1018, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: Series are different
Series values are different (25.0 %)
[left]:  [0.00050354, 2.75732, -2.34081, 12.0699]
[right]: [0.000502824783325, 2.75732088089, -2.34080505371, 12.06990242]
----------------------------------------------------------------------
Ran 11145 tests in 664.680s
FAILED (SKIP=109, failures=1)

@parthea
Copy link
Contributor Author

parthea commented Sep 12, 2016

@jreback At your earliest convenience, please restart the Travis build for this PR. I think it is failing due to a once-off failure:

======================================================================
FAIL: test_sum (pandas.tests.frame.test_analytics.TestDataFrameAnalytics)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/pydata/pandas/pandas/tests/frame/test_analytics.py", line 420, in test_sum
    check_less_precise=True)
  File "/home/travis/build/pydata/pandas/pandas/tests/frame/test_analytics.py", line 897, in _check_stat_op
    check_less_precise=check_less_precise)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 1181, in assert_series_equal
    obj='{0}'.format(obj))
  File "testing.pyx", line 59, in pandas._testing.assert_almost_equal (pandas/src/testing.c:3262)
  File "testing.pyx", line 173, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2590)
  File "/home/travis/build/pydata/pandas/pandas/util/testing.py", line 1018, in raise_assert_detail
    raise AssertionError(msg)
AssertionError: Series are different
Series values are different (25.0 %)
[left]:  [0.00050354, 2.75732, -2.34081, 12.0699]
[right]: [0.000502824783325, 2.75732088089, -2.34080505371, 12.06990242]
----------------------------------------------------------------------
Ran 11145 tests in 664.680s
FAILED (SKIP=109, failures=1)

@parthea
Copy link
Contributor Author

parthea commented Sep 13, 2016

@jreback Travis is green

@jreback jreback closed this in f363236 Sep 13, 2016
@jreback
Copy link
Contributor

jreback commented Sep 13, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas.io.gbq verify_schema seems to be too strict.
3 participants