Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Series ops with object dtype may incorrectly fail #13072

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 3, 2016

This must be after #13069.

@sinhrks sinhrks added Bug Dtype Conversions Unexpected or buggy dtype conversions Numeric Operations Arithmetic, Comparison, and Logical operations labels May 3, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone May 3, 2016
@codecov-io
Copy link

codecov-io commented May 4, 2016

Current coverage is 84.14%

Merging #13072 into master will increase coverage by +<.01%

@@             master     #13072   diff @@
==========================================
  Files           137        137          
  Lines         50287      50239    -48   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42312      42272    -40   
+ Misses         7975       7967     -8   
  Partials          0          0          
  1. 4 files (not in diff) in pandas/tseries were modified. more
    • Misses -4
    • Hits -26
  2. 2 files (not in diff) in pandas/io were modified. more
    • Misses -3
    • Hits -3
  3. 2 files (not in diff) in pandas/core were modified. more
  4. 2 files (not in diff) in pandas were modified. more
    • Misses -2
    • Hits -22

Powered by Codecov. Last updated by 43989fd...f814410

@sinhrks sinhrks changed the title (WIP) BUG: Series ops with object dtype may incorrectly fail BUG: Series ops with object dtype may incorrectly fail May 7, 2016
@@ -638,17 +639,33 @@ def wrapper(left, right, name=name, na_op=na_op):
if ridx is not None:
rvalues = algos.take_1d(rvalues, ridx)

arr = na_op(lvalues, rvalues)

Copy link
Contributor

@jreback jreback May 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would either do this directly in na_op (not sure if that's easy/possible) or

def safe_na_op(lvalues, rvalues): # better name...
     try:
           return na_op(lvalues, rvalues)
     except Exception:
           if is_object_dtype(........):

then

result = wrrap_results(maybe_na_op(lvalues, rvalues))
# only need 1 return statement (you may need to: ``name = left.name`` etc in the scalar section
return left._constructor(result, index=index, name=name, dtype=dtype)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what you mean? The travis failure is caused by boto.

@jreback jreback closed this in 4aa6323 May 11, 2016
@sinhrks sinhrks deleted the object_ops branch May 11, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series with datetime-like object ops raises TypeError
3 participants