Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: filter (with dropna=False) when there are no groups fulfilling the condition #12776

Closed
wants to merge 1 commit into from
Closed

BUG: filter (with dropna=False) when there are no groups fulfilling the condition #12776

wants to merge 1 commit into from
+17 −1

Conversation

jonaslb
Copy link
Contributor

@jonaslb jonaslb commented Apr 2, 2016

Implemented the fix for #12768 which was proposed in the bug report.

@jreback jreback added this to the 0.18.1 milestone Apr 2, 2016
jreback
jreback reviewed Apr 2, 2016
View reviewed changes
pandas/tests/test_groupby.py
def test_filter_out_all_groups_in_df_dropna_false(self):
# GH12768
df = pd.DataFrame({'a': [1,1,2], 'b': [1,2,0]})
res = df.groupby('a')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for dropna=True as well. lgtm otherwise. ping when green.

@jreback
Copy link
Contributor

jreback commented Apr 2, 2016

run: git diff master | flake8 --diff to see PEP issues

@jonaslb
BUG: Filtering a groupby object with dropnan=False and no groups fulf…
14bd7d7 
…illing req.

Closes #12768

Added test for bug #12768

Added whatsnew entry for fix for #12768

Added another test for the case where dropna=True

Added some spaces in my tests that I missed previously.. (passes flake8 now)
@jreback jreback closed this in 64977f1 Apr 3, 2016
@jreback
Copy link
Contributor

jreback commented Apr 3, 2016

thanks @jonaslb

@jreback jreback mentioned this pull request Jun 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Groupby
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.

BUG: filter (with dropna=False) when there are no groups fulfilling the condition
2 participants
@jonaslb @jreback