Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove private_key and verbose from gbq #34640

Closed
charlesdong1991 opened this issue Jun 8, 2020 · 4 comments · Fixed by #34654
Closed

CLN: remove private_key and verbose from gbq #34640

charlesdong1991 opened this issue Jun 8, 2020 · 4 comments · Fixed by #34654
Assignees
@lathamri
Labels
Clean good first issue
Milestone
1.2

Comments

@charlesdong1991
Copy link
Member

charlesdong1991 commented Jun 8, 2020 •
edited
Loading

Since verbose and private_key have been deprecated since #30200, we should also remove both from function since they are not used at all? see them in read_gbq and to_gbq, e.g.

pandas/pandas/io/gbq.py

Line 33 in 24857a2

private_key=None,

pandas/pandas/io/gbq.py

Line 34 in 24857a2

verbose=None,

@charlesdong1991 charlesdong1991 added Bug Needs Triage Issue that has not been reviewed by a pandas team member Clean Deprecate Functionality to remove in pandas good first issue and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas labels Jun 8, 2020
@charlesdong1991 charlesdong1991 added this to the Contributions Welcome milestone Jun 8, 2020
@charlesdong1991 charlesdong1991 changed the title DEPR: remove private_key and verbose from gbq CLN: remove private_key and verbose from gbq Jun 8, 2020
parkdj1 added a commit to parkdj1/pandas that referenced this issue Jun 8, 2020
@parkdj1
pandas-dev#34640: CLN: remove 'private_key' and 'verbose' from gbq
9083e5d
@parkdj1 parkdj1 mentioned this issue Jun 8, 2020
Merged
4 tasks
@faraz16iqbal
Copy link

Is this issue still up for grabs?

@lathamri lathamri removed their assignment Jun 11, 2020
@lathamri
Copy link

take

lathamri pushed a commit to lathamri/pandas that referenced this issue Jun 11, 2020
@rileylatham1
CLN: remove verbose and private_key references pandas-dev#34640
7746e76
@lathamri lathamri mentioned this issue Jun 11, 2020
Closed
5 tasks
@faraz16iqbal
Copy link

taking up this task

@charlesdong1991
Copy link
Member Author

Hey, @faraz16iqbal thanks for your interest in helping out, there is an open PR already to fix this issue.

Feel free to look for other issues!

@jreback jreback modified the milestones: Contributions Welcome, 1.2 Sep 13, 2020
jreback pushed a commit that referenced this issue Sep 24, 2020
@parkdj1
#34640: CLN: remove 'private_key' and 'verbose' from gbq (#34654)
f34a56b
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@parkdj1
pandas-dev#34640: CLN: remove 'private_key' and 'verbose' from gbq (p…
15f5cac 
…andas-dev#34654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lathamri lathamri

Labels
Clean good first issue
Projects
None yet
Milestone
1.2
5 participants
@jreback @charlesdong1991 @alimcmaster1 @lathamri @faraz16iqbal