Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix the docstring of to_stata in pandas/core/frame.py #22896

Closed
datapythonista opened this issue Sep 29, 2018 · 8 comments · Fixed by #23152
Closed

DOC: Fix the docstring of to_stata in pandas/core/frame.py #22896

datapythonista opened this issue Sep 29, 2018 · 8 comments · Fixed by #23152

Comments

@datapythonista
Copy link
Member

datapythonista commented Sep 29, 2018

pandas docstring are expected to follow the format defined in https://pandas.pydata.org/pandas-docs/stable/contributing_docstring.html

This includes among other things:

  • There is a short description fitting in one line (there can be a longer one after that).
  • The description of the parameters, the returns section, and the see also items, starts with a capital letter and ends with a period.
  • In the Return section there is no name before the type (e.g. transformed : Series) but just the type (e.g. Series) in the first line.
  • The examples are valid PEP-8 code, and when executed, they produce the shown input.

We should make the required adjustments in the docstring of the function to_stata in pandas/core/frame.py.

We should validate the docstring with our validator (which does not validate all the formats, but some):

  • ./scripts/validate_docstrings.py pandas.DataFrame.to_stata

And we should validate the PEP-8 of the examples (note that the next command will validate the PEP-8 of all examples, just make sure that none of the shown is in the function being addressed, the rest will be fixed in separate issues):

  • flake8 --doctests pandas/core/frame.py
@leeyspaul
Copy link
Contributor

leeyspaul commented Sep 30, 2018

Working on this issue, referenced from #22899 .

@datapythonista
Copy link
Member Author

@leeyspaul are you working on this? I don't think anyone else is finally working on it.

@ryankarlos
Copy link
Contributor

@datapythonista is this issue still open ? I would like to work on it if it is - otherwise, any other ones still open (most DOC issues seem taken) ?

@datapythonista
Copy link
Member Author

Yes, this is open and I don't think there is a PR for it, or anyone working on it. So, please go ahead.

@ryankarlos
Copy link
Contributor

ryankarlos commented Oct 12, 2018

@datapythonista Thanks. Just to clarify, I don't see a Return sections currently included in the to_stata docstring - did you want that added in presumably rather than modified ?

@datapythonista
Copy link
Member Author

Yes, I was just mentioning examples, but the idea is that the docstring is as good as possible and follow all the standards named in the documentation.

@ryankarlos
Copy link
Contributor

Thanks, will do !

@ryankarlos
Copy link
Contributor

@datapythonista Just submitted a PR, let me know if there are any modifications required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants