Add _validate_shape

pandas-dev · Dec 18, 2018 · 7939d93 · 7939d93
1 parent f4315ac
commit 7939d93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pandas/core/arrays/base.py b/pandas/core/arrays/base.py
@@ -862,6 +862,10 @@ def _add_comparison_ops(cls):
         cls.__le__ = cls._create_comparison_method(operator.le)
         cls.__ge__ = cls._create_comparison_method(operator.ge)
 
+    def _validate_shape(self, other):
+        if len(self) != len(other):
+            raise ValueError('Lengths must match to compare')
+
 
 class ExtensionScalarOpsMixin(ExtensionOpsMixin):
     """

diff --git a/pandas/core/arrays/period.py b/pandas/core/arrays/period.py
@@ -68,8 +68,7 @@ def wrapper(self, other):
         elif isinstance(other, cls):
             self._check_compatible_with(other)
 
-            if other.ndim > 0 and len(self) != len(other):
-                raise ValueError('Lengths must match to compare')
+            self._validate_shape(other)
 
             if not_implemented:
                 return NotImplemented