Remove uses of warnings.catch_warnings (#2690) #2692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
warnings.catch_warnings
, thus preventing the rest of the global warnings registry (and the ensuing repetition of warnings filtered with the "default" action) as discussed at #2690.Checklist:
CHANGES.rst
summarizing the change and linking to the issue.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.werkzeug.wsgi._make_chunk_iter
really have to issue a deprecation warning?Question
Since
_make_chunk_iter
is not document API, can the deprecation warning it emits just be deleted? Doing so would remove several cases wherecatch_warnings
was suppressing warnings from internal calls.