Update sessions.py

Fix for Redis / mongo/memcache/filesystem Not for sql Do not save session on each request if session.modified = False
pallets-eco · Apr 25, 2023 · eb5c19d · eb5c19d
1 parent 9f591b5
commit eb5c19d
Showing 1 changed file with 21 additions and 17 deletions.
diff --git a/flask_session/sessions.py b/flask_session/sessions.py
@@ -164,9 +164,10 @@ def save_session(self, app, session, response):
         if self.has_same_site_capability:
             conditional_cookie_kwargs["samesite"] = self.get_cookie_samesite(app)
         expires = self.get_expiration_time(app, session)
-        val = self.serializer.dumps(dict(session))
-        self.redis.setex(name=self.key_prefix + session.sid, value=val,
-                         time=total_seconds(app.permanent_session_lifetime))
+        if session.modified:
+            val = self.serializer.dumps(dict(session))
+            self.redis.setex(name=self.key_prefix + session.sid, value=val,
+                             time=total_seconds(app.permanent_session_lifetime))
         if self.use_signer:
             session_id = self._get_signer(app).sign(want_bytes(session.sid))
         else:
@@ -283,12 +284,13 @@ def save_session(self, app, session, response):
         if self.has_same_site_capability:
             conditional_cookie_kwargs["samesite"] = self.get_cookie_samesite(app)
         expires = self.get_expiration_time(app, session)
-        if not PY2:
-            val = self.serializer.dumps(dict(session), 0)
-        else:
-            val = self.serializer.dumps(dict(session))
-        self.client.set(full_session_key, val, self._get_memcache_timeout(
-                        total_seconds(app.permanent_session_lifetime)))
+        if session.modified:
+            if not PY2:
+                val = self.serializer.dumps(dict(session), 0)
+            else:
+                val = self.serializer.dumps(dict(session))
+            self.client.set(full_session_key, val, self._get_memcache_timeout(
+                            total_seconds(app.permanent_session_lifetime)))
         if self.use_signer:
             session_id = self._get_signer(app).sign(want_bytes(session.sid))
         else:
@@ -362,9 +364,10 @@ def save_session(self, app, session, response):
         if self.has_same_site_capability:
             conditional_cookie_kwargs["samesite"] = self.get_cookie_samesite(app)
         expires = self.get_expiration_time(app, session)
-        data = dict(session)
-        self.cache.set(self.key_prefix + session.sid, data,
-                       total_seconds(app.permanent_session_lifetime))
+        if session.modified:
+            data = dict(session)
+            self.cache.set(self.key_prefix + session.sid, data,
+                           total_seconds(app.permanent_session_lifetime))
         if self.use_signer:
             session_id = self._get_signer(app).sign(want_bytes(session.sid))
         else:
@@ -452,11 +455,12 @@ def save_session(self, app, session, response):
         if self.has_same_site_capability:
             conditional_cookie_kwargs["samesite"] = self.get_cookie_samesite(app)
         expires = self.get_expiration_time(app, session)
-        val = self.serializer.dumps(dict(session))
-        self.store.update({'id': store_id},
-                          {'id': store_id,
-                           'val': val,
-                           'expiration': expires}, True)
+        if session.modified:
+            val = self.serializer.dumps(dict(session))
+            self.store.update({'id': store_id},
+                              {'id': store_id,
+                               'val': val,
+                               'expiration': expires}, True)
         if self.use_signer:
             session_id = self._get_signer(app).sign(want_bytes(session.sid))
         else: