Support ActiveJob 7.2 enqueue_after_transaction_commit
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
from
7dd998f to
ca88e36
Compare
joshuay03
changed the title
ActiveRecord 7.2 enqueue_after_transaction_commit
joshuay03
changed the title
ActiveRecord 7.2 enqueue_after_transaction_commitActiveJob 7.2 enqueue_after_transaction_commit
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
2 times, most recently
from
4cf3cd6 to
5ddaac8
Compare
joshuay03
commented
Apr 15, 2024
| @@ -143,3 +145,5 @@ This, for example, makes Isolator compatible with Rails multi-database apps. | |||
| [@Mange]: https://github.com/Mange | |||
| [@tomgi]: https://github.com/tomgi | |||
| [@tagirahmad]: https://github.com/tagirahmad | |||
| [@arthurWD]: https://github.com/arthurWD | |||
palkan
reviewed
Apr 15, 2024
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
from
5ddaac8 to
d50ea62
Compare
joshuay03
commented
Apr 18, 2024
palkan
reviewed
Apr 18, 2024
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
2 times, most recently
from
aca583d to
7eeba75
Compare
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
from
7eeba75 to
c91c351
Compare
joshuay03
force-pushed
the
support-enqueue-after-transaction-commit
branch
from
c91c351 to
1a07957
Compare
|
Thanks! I'll take care of the mailer specs (looks like we need to cover both pre 7.2 and post 7.2 cases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Ref: rails/rails#51426
Disables the throwing of
Isolator::BackgroundJobErrorfor jobs queued from within transactions if the newActiveJobconfigenqueue_after_transaction_commitis enabled.What changes did you make? (overview)
Updated the
active_jobadapter to be disabled ifenqueue_after_transaction_commitis enabled globally or by the configured queue adapter.Is there anything you'd like reviewers to focus on?
Checklist