Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javadoc for DANGEROUS_DISABLE_SYMPATHETIC_CLIENT_QOS #2976

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Improve Javadoc for DANGEROUS_DISABLE_SYMPATHETIC_CLIENT_QOS #2976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b69e6b
Improve Javadoc for DANGEROUS_DISABLE_SYMPATHETIC_CLIENT_QOS
ash211 Oct 1, 2024
018a8b5
Add generated changelog entries
svc-changelog Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-2976.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Improve Javadoc for DANGEROUS_DISABLE_SYMPATHETIC_CLIENT_QOS
links:
- https://github.com/palantir/conjure-java-runtime/pull/2976
10 changes: 7 additions & 3 deletions client-config/src/main/java/com/palantir/conjure/java/client/config/ClientConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,13 @@ enum ClientQoS {
ENABLED,

/**
* Disables the client-side sympathetic QoS. Consumers should almost never use this option, reserving it for
* where there are known issues with the QoS interaction. Please consult project maintainers if applying this
* option.
* Disables the client-side sympathetic QoS.
*
* <p>This turns off all client-side concurrency limiters / queueing and immediately submits requests to the
* network.
*
* <p>Consumers should almost never use this option, reserving it for where there are known issues with the QoS
* interaction. Please consult project maintainers if applying this option.
*/
DANGEROUS_DISABLE_SYMPATHETIC_CLIENT_QOS
}
Expand Down