[core] fix(HotkeysProvider): avoid unnecessary children re-renders #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braeden
reviewed
Jan 11, 2024
| // if we are working with an existing context, we don't need to generate our own dialog | ||
| return ( | ||
| <HotkeysContext.Provider value={[state, dispatch]}> | ||
| <HotkeysContext.Provider value={[reducedState, dispatch]}> |
There was a problem hiding this comment.
(totally aware this is a draft) But I think we actually want to memo this reference itself too. eg.
const memoValue = React.useMemo(() => [reducedState, dispatch], [])Also have seen this show up in some perf-profiles, but haven't had the time to follow-up. Without a memo, each time this provider renders, it also re-renders every single consuming child (even if state/dispatch) haven't changed.
Edit: #6652
2 tasks
|
closing in favor of #6652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5178
Checklist
Changes proposed in this pull request:
WIP - attempts to apply https://gist.github.com/stephen/873773683fc15d1fb290b338a6c59d38
Reviewers should focus on:
No regressions in hotkey APIs
No regressions in advanced usage APIs with nested providers: #4767
Screenshot
N/A