[core] feat(Callout): visual modernisation #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2023 11:40
CPerinet
commented
Jan 10, 2023
| @@ -8,7 +8,7 @@ Callout | |||
|
|
|||
| Markup: | |||
| <div class="#{$ns}-callout {{.modifier}}"> | |||
| <h4 class="#{$ns}-heading">Callout Heading</h4> | |||
| <h5 class="#{$ns}-heading">Callout Heading</h5> | |||
There was a problem hiding this comment.
In line with the dialog update, reducing the heading level to fit better in dense UIs.
CPerinet
commented
Jan 10, 2023
| @@ -25,20 +25,20 @@ Styleguide callout | |||
| @include running-typography(); | |||
| background-color: rgba($gray3, 0.15); | |||
| border-radius: $pt-border-radius; | |||
| padding: $pt-grid-size ($pt-grid-size * 1.2) ($pt-grid-size * 0.9); | |||
| padding: $pt-grid-size * 1.5; | |||
There was a problem hiding this comment.
- Make the spacing consistent all around.
- Increase inner spacing.
added 2 commits
January 10, 2023 12:00
CPerinet
commented
Jan 10, 2023
| @@ -93,6 +97,7 @@ Styleguide callout | |||
|
|
|||
| .#{$ns}-dark & { | |||
| background-color: rgba($color, 0.2); | |||
| color: map-get($pt-dark-intent-text-colors, $intent); | |||
There was a problem hiding this comment.
Make default text colour intent. Adding accessibility checks
adidahiya
approved these changes
Jan 10, 2023
adidahiya
changed the title
|
Color changes LGTM. I also tested contrast without the docs example container background (by default, it increases the apparent contrast), because I think
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition for modernisation of callouts. Reduce unnecessary visual drag while retaining prominence.
h4toh520pxto16pxAccessibility checks
Given background colours uses opacity, I chose to evaluate accessibility with the callout on a
$white/$light-gray5background for light theme and$dark-gray1/$dark-gray2for dark theme.