flex button #2078
flex button #2078
Conversation
to streamline testing of states
- vertical buttons automatically align left and push rightIcon to right side! - loading easily hides this container without needing to wrap children!
fix row margin when large, right icon spacing in CSS APIPreview: documentation | landing | table |
| * to the appropriate side. `icon` and `rightIcon` will be pushed to either side. | ||
| * @default "center" | ||
| */ | ||
| align?: "left" | "center" | "right"; |
There was a problem hiding this comment.
this conflicts somewhat with the NavbarGroup align prop -- here, you are referring to the alignment of content while for NavbarGroup (as well as most design tools), align refers to the component's alignment in its container. I suggest renaming this to textAlignment or alignText
There was a problem hiding this comment.
mmm yes good catch @adidahiya! i'll go with alignText
| [Classes.LARGE]: large, | ||
| [Classes.MINIMAL]: minimal, |
There was a problem hiding this comment.
would prefer not to add tangential new props in this PR.
i plan to add modifier props across the board after 2.0 (non-breaking)
| fill: false, | ||
| iconOnly: false, | ||
| large: false, | ||
| minimal: false, |
There was a problem hiding this comment.
small modifier in examples would be neat
There was a problem hiding this comment.
ButtonGroup doesn't have a small prop.
let's wait on that, i want to add modifier props everywhere
let flex figure out heights of numeric-input buttons 👌Preview: documentation | landing | table |
| * to the appropriate side. `icon` and `rightIcon` will be pushed to either side. | ||
| * @default "center" | ||
| */ | ||
| align?: "left" | "center" | "right"; |
There was a problem hiding this comment.
this conflicts somewhat with the NavbarGroup align prop -- here, you are referring to the alignment of content while for NavbarGroup (as well as most design tools), align refers to the component's alignment in its container. I suggest renaming this to textAlignment or alignText
|
otherwise lgtm |
giladgray
force-pushed
the
gg/flex-button
branch
from
ff00e9d to
7d51281
Compare
align => alignText, add more button classesPreview: documentation | landing | table |
Merge branch 'develop' of github.com:palantir/blueprint into gg/flex-buttonPreview: documentation | landing | table |
Changes proposed in this pull request:
pt-button-base()is inline flex row.pt-fillcontaineralignTextprop toButtonandButtonGroup(and examples)Reviewers should focus on:
alignprop: play with it in bothButtonGroupJS examples