Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Paketo Stacks RFC 0004: Jammy Jellyfish #1

Closed
3 tasks
Tracked by #133
fg-j opened this issue May 10, 2022 · 1 comment · Fixed by #2
Closed
3 tasks
Tracked by #133

Implement Paketo Stacks RFC 0004: Jammy Jellyfish #1

fg-j opened this issue May 10, 2022 · 1 comment · Fixed by #2
Assignees
@robdimsdale @sophiewigmore

Comments

@fg-j
Copy link

fg-j commented May 10, 2022 •
edited
Loading

Paketo Stacks RFC 0004 states that Paketo should support a "base" stack on top of Ubuntu Jammy Jellyfish. To implement this RFC:

  • Determine which OS packages should be installed on the Base Jammy stack. These may be identical to those installed on the bionic Base stack. (See the bionic base repo)
  • Create a stack descriptor file for this stack and check it into this repo. The descriptor should have the following attributes:
    • stack id: io.buildpacks.stacks.jammy
    • the UID for build and run phases should differ (but be in the same group)
  • Set up automation on this repo that builds the stack using jam create-stack and publishes the stack to the appropriate tags:
    • paketobuildpacks/build-jammy-base:latest
    • paketobuildpacks/build-jammy-base:1.2.3
    • paketobuildpacks/run-jammy-base:latest
    • paketobuildpacks/run-jammy-base:1.2.3
@fg-j fg-j mentioned this issue May 10, 2022
Closed
3 tasks
@fg-j fg-j moved this to ❓Not scoped in Paketo Workstreams May 10, 2022
@fg-j fg-j added the status/blocked This issue has been triaged and resolving it is blocked on some other issue label May 23, 2022
@fg-j
Copy link
Author

fg-j commented May 23, 2022

We'd like to make more progress on paketo-buildpacks/jammy-tiny-stack#1 before picking this up – the precedent set by Tiny can be followed here.

@fg-j fg-j removed the status/blocked This issue has been triaged and resolving it is blocked on some other issue label Jun 21, 2022
phil9909 added a commit to sap-contributions/jammy-base-stack that referenced this issue Jun 22, 2022
@kulhadia @phil9909
Initial stack implementation
dc6d628 
Based on the tiny variant: https://github.com/paketo-buildpacks/jammy-tiny-stack/tree/e9a41436b06d3c3fa2960980ea98be36796ab3b6

Changes:
- Renamed
  - search and replace `tiny` with `base`
  - change stack id from `io.buildpacks.stacks.jammy.base` to `io.buildpacks.stacks.jammy` as suggested in paketo-buildpacks#1
- Updated README
- Updated description
- Recreated the `Dockerfile` of the run image based on the build image `Dockerfile`
- Added some packages from bionic base stack
- Updated the integration test (use a simple java app instead of go)

Co-authored-by: Philipp Stehle <[email protected]>
@phil9909 phil9909 mentioned this issue Jun 22, 2022
Merged
5 tasks
@robdimsdale robdimsdale moved this from ❓Not scoped to 📨 PR Opened in Paketo Workstreams Jun 22, 2022
@ryanmoran ryanmoran linked a pull request Jun 22, 2022 that will close this issue
Initial stack implementation #2
Merged
5 tasks
sophiewigmore pushed a commit that referenced this issue Jun 24, 2022
@phil9909 @kulhadia @c0d1ngm0nk3y
Initial stack implementation (#2)
29c3de3 
* Initial stack implementation

Based on the tiny variant: https://github.com/paketo-buildpacks/jammy-tiny-stack/tree/e9a41436b06d3c3fa2960980ea98be36796ab3b6

Changes:
- Renamed
  - search and replace `tiny` with `base`
  - change stack id from `io.buildpacks.stacks.jammy.base` to `io.buildpacks.stacks.jammy` as suggested in #1
- Updated README
- Updated description
- Recreated the `Dockerfile` of the run image based on the build image `Dockerfile`
- Added some packages from bionic base stack
- Updated the integration test (use a simple java app instead of go)

Co-authored-by: Philipp Stehle <[email protected]>

* address review comments

Co-authored-by: Philipp Stehle <[email protected]>

* remove explicit libc6

Co-authored-by: Philipp Stehle <[email protected]>

Co-authored-by: Sumit Kulhadia <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Repository owner moved this from 📨 PR Opened to ✅ Done in Paketo Workstreams Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robdimsdale robdimsdale

@sophiewigmore sophiewigmore

Labels
None yet
Projects
Paketo Workstreams
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial stack implementation sap-contributions/jammy-base-stack
3 participants
@robdimsdale @sophiewigmore @fg-j