-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stacks automation to central repo #476
Conversation
@fg-j what needs to be done for this PR to be taken out of "draft" and become ready for review? |
Basically, I just need to shift some of our refactors out of the jammy tiny stack and move them here. |
by adding a step that aggregates release assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate some form of testing for the actions that are written in Go as I imagine that they are the actions that are the most complicated and if they needed to be changed in the future then having tests would be a great benefit.
@ForestEckhardt agreed that testing would be very useful here. Considering we've already started moving forward with the Jammy base/full stacks, would you be comfortable with the addition of testing as a separate PR? I'm thinking that may be the move so that the new repositories can be built from the get go with the shared tooling. If not, those repositories will probably just use copies of what Jammy Tiny has anyways, which are untested |
The changes here look good to me |
@sophiewigmore For sure, could we just get an issue to track that really quickly and then I am good to go. |
#482 can be transferred to this repo |
@fg-j Do you have issues for |
There aren't issues for those. I can expand the issue to include coverage for those actions as well. |
@fg-j can you also update the github-config repo |
and clean up update tools workflow
Summary
To implement paketo-buildpacks/rfcs#197 and paketo-buildpacks/stacks#133, the new stacks repositories require new automation.
The automation checked in here is based on my fork of the jammy-tiny-stack repository. Most of the automation included here is already running on the fork.
There are a couple of notable differences between this PR and the automation implemented on the jammy-tiny-stack repo:
Checklist