Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacks automation to central repo #476

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Add stacks automation to central repo #476

merged 10 commits into from
Jun 22, 2022

Conversation

fg-j
Copy link

@fg-j fg-j commented Jun 13, 2022

Summary

To implement paketo-buildpacks/rfcs#197 and paketo-buildpacks/stacks#133, the new stacks repositories require new automation.

The automation checked in here is based on my fork of the jammy-tiny-stack repository. Most of the automation included here is already running on the fork.

There are a couple of notable differences between this PR and the automation implemented on the jammy-tiny-stack repo:

  • There is one Create Release step in the release workflow instead of two. The list of release assets is now constructed before the release step, and accounts for the with- and without-USNs cases.
  • There are a couple of places where the jammy-tiny-stack automation hard-codes names related to the stack and/or linux distribution. I've added steps that parse this info from the Github repo name. These enforce/expect the same repo naming scheme outlined in the Jammy RFC and Bionic Updates RFC.
  • The create release and push image workflows use the newly refactored File Issue action in this repo.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@fg-j fg-j marked this pull request as ready for review June 13, 2022 22:10
@fg-j fg-j requested a review from a team as a code owner June 13, 2022 22:10
@fg-j fg-j marked this pull request as draft June 16, 2022 18:38
@robdimsdale
Copy link
Member

@fg-j what needs to be done for this PR to be taken out of "draft" and become ready for review?

@fg-j
Copy link
Author

fg-j commented Jun 22, 2022

Basically, I just need to shift some of our refactors out of the jammy tiny stack and move them here.

@fg-j fg-j marked this pull request as ready for review June 22, 2022 18:48
Copy link
Contributor

@ForestEckhardt ForestEckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate some form of testing for the actions that are written in Go as I imagine that they are the actions that are the most complicated and if they needed to be changed in the future then having tests would be a great benefit.

@sophiewigmore
Copy link
Member

sophiewigmore commented Jun 22, 2022

@ForestEckhardt agreed that testing would be very useful here. Considering we've already started moving forward with the Jammy base/full stacks, would you be comfortable with the addition of testing as a separate PR? I'm thinking that may be the move so that the new repositories can be built from the get go with the shared tooling. If not, those repositories will probably just use copies of what Jammy Tiny has anyways, which are untested

@sophiewigmore
Copy link
Member

The changes here look good to me

@ForestEckhardt
Copy link
Contributor

@sophiewigmore For sure, could we just get an issue to track that really quickly and then I am good to go.

@fg-j
Copy link
Author

fg-j commented Jun 22, 2022

#482 can be transferred to this repo

@ForestEckhardt
Copy link
Contributor

@fg-j Do you have issues for diff-package-receipts and release-notes as well or do those need to be generated?

@fg-j
Copy link
Author

fg-j commented Jun 22, 2022

There aren't issues for those. I can expand the issue to include coverage for those actions as well.

@sophiewigmore
Copy link
Member

@fg-j can you also update the github-config repo update-tools workflow to include bumping the stacks-related tools?

and clean up update tools workflow
@fg-j fg-j requested a review from sophiewigmore June 22, 2022 21:56
@sophiewigmore sophiewigmore merged commit 0713228 into main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants