Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-879,IOBP-880] Upgrade react-native-vision-camera to version 4.3.1 #6216

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 26, 2024

Short description

This PR upgrades the react-native-vision-camera version to the v.4.3.1 that fixes two of the bugs that are also reported in their issues.

  1. IOBP-879 The Camera is working fine on most devices. However, there are a few on which it just won't work. The camera will simply try to load and stay black. (Black Screen on POCO X4🐛  mrousavy/react-native-vision-camera#2716)
  2. IOBP-880 On some devices the camera image appears horizontally stretched (Stretched camera image 🐛  mrousavy/react-native-vision-camera#2364)

How to test

  • Please test this PR on a real device to check that the camera is working correctly from the Scan section tab bar.

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Sep 26, 2024
@Hantex9 Hantex9 requested a review from a team as a code owner September 26, 2024 10:17
@pagopa-github-bot pagopa-github-bot changed the title chore: [IOBP-879,IOBP-880] Upgrade react-native-vision-camera to version 4.3.1 fix: [IOBP-879,IOBP-880] Upgrade react-native-vision-camera to version 4.3.1 Sep 26, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 26, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🐞 IOBP-879: [Paga un avviso > Inquadra] Impossibilità di scansionare un QRCode per schermata nera
  • 🐞 IOBP-880: [Paga un avviso > Inquadra] l'immagine viene "distorta" dal dispositivo

Generated by 🚫 dangerJS against a5b2ab3

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.16%. Comparing base (4f204b4) to head (a5b2ab3).
Report is 580 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6216      +/-   ##
==========================================
- Coverage   48.42%   47.16%   -1.27%     
==========================================
  Files        1488     1790     +302     
  Lines       31617    36156    +4539     
  Branches     7669     8625     +956     
==========================================
+ Hits        15311    17052    +1741     
- Misses      16238    19038    +2800     
+ Partials       68       66       -2     

see 1404 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f841bc...a5b2ab3. Read the comment docs.

ios/Podfile.lock Outdated Show resolved Hide resolved
ios/Podfile.lock Outdated Show resolved Hide resolved
ios/Podfile.lock Outdated Show resolved Hide resolved
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on both my Android and iOS test physical devices.

@Hantex9 Hantex9 merged commit f19e5d1 into master Oct 11, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-879-880-upgrade-react-native-vision-camera branch October 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants